From f2137a4e84e0c9235100c5bf2f8d40c7b6ff48df Mon Sep 17 00:00:00 2001 From: pass0 <50512859+pass0@users.noreply.github.com> Date: Tue, 2 Jul 2019 18:53:41 +0800 Subject: [PATCH] Update "fps_tutorial/part_one" (#2547) Basis vectors are already normalized, delete redundant code ".Normalized()" --- tutorials/3d/fps_tutorial/part_one.rst | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tutorials/3d/fps_tutorial/part_one.rst b/tutorials/3d/fps_tutorial/part_one.rst index 38a318ed6..a2189780d 100644 --- a/tutorials/3d/fps_tutorial/part_one.rst +++ b/tutorials/3d/fps_tutorial/part_one.rst @@ -189,8 +189,9 @@ Add the following code to ``Player.gd``: input_movement_vector = input_movement_vector.normalized() - dir += -cam_xform.basis.z.normalized() * input_movement_vector.y - dir += cam_xform.basis.x.normalized() * input_movement_vector.x + # Basis vectors are already normalized. + dir += -cam_xform.basis.z * input_movement_vector.y + dir += cam_xform.basis.x * input_movement_vector.x # ---------------------------------- # ---------------------------------- @@ -304,8 +305,9 @@ Add the following code to ``Player.gd``: inputMovementVector = inputMovementVector.Normalized(); - _dir += -camXform.basis.z.Normalized() * inputMovementVector.y; - _dir += camXform.basis.x.Normalized() * inputMovementVector.x; + // Basis vectors are already normalized. + _dir += -camXform.basis.z * inputMovementVector.y; + _dir += camXform.basis.x * inputMovementVector.x; // ------------------------------------------------------------------- // -------------------------------------------------------------------