From ca3bac9a42753b95468e1e5427b5ac21766cd81d Mon Sep 17 00:00:00 2001 From: bbhtt Date: Sat, 23 Aug 2025 07:53:27 +0530 Subject: [PATCH] pr-check: Don't post the domain comment until checklists are complete --- .github/workflows/pr-check.yml | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index f384b2d..3ddd780 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -113,18 +113,6 @@ jobs: if [ "$EXIT_CODE" -ne 0 ]; then echo "PR title validation failed" BLOCKED=1 - else - DOMAIN=$(curl -sSL "$DOMAIN_SCRIPT_URL" | python3 - "$PR_TITLE") - if [ -n "$DOMAIN" ] && [ "$DOMAIN" != "None" ]; then - echo "Domain is: $DOMAIN" - VERIF_URL="https://$DOMAIN/.well-known/org.flathub.VerifiedApps.txt" - VERIF_COMMENT="If you intend to verify this app, please confirm that you can upload $VERIF_URL. Otherwise, ignore this" - DOMAIN_COMMENT="$DOMAIN_COMMENT_PARTIAL $DOMAIN. $VERIF_COMMENT. Please comment if this incorrect." - if ! comment_exists_full "$DOMAIN_COMMENT"; then - echo "Did not find domain comment, commenting" - gh pr comment "$PR_NUM" --body "$DOMAIN_COMMENT" - fi - fi fi CHECKLIST_PRESENT=$(printf "%s\n" "$PR_BODY" | grep -cE '^- ?\[[xX]\] [A-Za-z]+' || true) @@ -151,6 +139,17 @@ jobs: echo "BLOCKED is set to $BLOCKED" if [ "$BLOCKED" -eq 0 ]; then + DOMAIN=$(curl -sSL "$DOMAIN_SCRIPT_URL" | python3 - "$PR_TITLE") + if [ -n "$DOMAIN" ] && [ "$DOMAIN" != "None" ]; then + echo "Domain is: $DOMAIN" + VERIF_URL="https://$DOMAIN/.well-known/org.flathub.VerifiedApps.txt" + VERIF_COMMENT="If you intend to verify this app, please confirm that you can upload $VERIF_URL. Otherwise, ignore this" + DOMAIN_COMMENT="$DOMAIN_COMMENT_PARTIAL $DOMAIN. $VERIF_COMMENT. Please comment if this incorrect." + if ! comment_exists_full "$DOMAIN_COMMENT"; then + echo "Did not find domain comment, commenting" + gh pr comment "$PR_NUM" --body "$DOMAIN_COMMENT" + fi + fi if label_exists_any "pr-check-blocked"; then echo "Removing pr-check-blocked label" gh pr edit "$PR_NUM" --remove-label "pr-check-blocked" || true